Skip to content

DropdownToggle: make aria-expanded optional #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

DropdownToggle: make aria-expanded optional #92

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/DropdownToggle.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ export interface UseDropdownToggleProps {
id: string;
ref: DropdownContextValue['setToggle'];
onClick: React.MouseEventHandler;
'aria-expanded': boolean;
'aria-expanded'?: boolean | null;
'aria-haspopup'?: true;
}

Expand Down Expand Up @@ -49,14 +49,16 @@ export function useDropdownToggle(): [
id,
ref: setToggle || noop,
onClick: handleClick,
'aria-expanded': !!show,
};

// This is maybe better down in an effect, but
// the component is going to update anyway when the menu element
// is set so might return new props.
if (menuElement && isRoleMenu(menuElement)) {
props['aria-haspopup'] = true;
props['aria-expanded'] = show || null;
} else {
props['aria-expanded'] = !!show;
}

return [props, { show, toggle }];
Expand Down