Migrate @popperjs/core to @floating-ui #133
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@popperjs/corewith@floating-uiusePopperusage example to the docsusePopperSpecto test the offset and flip middleware'sI tried my best to keep the existing interface of usePopper and only replace the underlying implantation for positioning by:
@popperjs/corewas positioning the floating div and its arrowI tested the Overlay and Dropdown manually in docs to make sure they work. Also all test are passing.
The solution is not the cleanest. It would be better to change all the components to use middleware's and remove any reference of popper. Anyhow, I wasn't sure how much breaking change should i introduce.