Skip to content

refactor: copy streams differently #842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 9, 2025
Merged

refactor: copy streams differently #842

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8ada332
refactor: copy streams differently
vonovak Jul 9, 2025
7dac11f
Create twenty-bikes-hunt.md
vonovak Jul 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/twenty-bikes-hunt.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@react-native-documents/picker": patch
---

refactor: copy streams differently
65 changes: 32 additions & 33 deletions ...ges/document-picker/android/src/main/java/com/reactnativedocumentpicker/FileOperations.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@ package com.reactnativedocumentpicker
import android.content.ContentResolver
import android.content.Context
import android.net.Uri
import android.os.Build
import android.os.FileUtils
import com.facebook.react.bridge.Arguments
import com.facebook.react.bridge.ReactApplicationContext
import com.facebook.react.bridge.ReactContext
Expand All @@ -18,7 +20,7 @@ import java.io.FileNotFoundException
import java.io.FileOutputStream
import java.io.IOException
import java.io.InputStream
import java.nio.channels.Channels
import java.io.OutputStream
import java.util.UUID

class FileOperations(private val uriMap: MutableMap<String, Uri>) {
Expand Down Expand Up @@ -119,23 +121,17 @@ class FileOperations(private val uriMap: MutableMap<String, Uri>) {
val destFileSafe = safeGetDestination(attemptedDestFile, destinationDir)

val copyStreamToFile: (InputStream?) -> Unit = { inputStream ->
if (inputStream == null) {
throw FileNotFoundException("No input stream was found for the source file")
}
FileOutputStream(destFileSafe).channel.use { destinationFileChannel ->
val inputChannel = Channels.newChannel(inputStream)
val size = destinationFileChannel.transferFrom(inputChannel, 0, Long.MAX_VALUE)
if (size == 0L) {
throw IOException("No data was copied to the destination file")
}
inputStream ?: throw FileNotFoundException("No input stream was found for the source file")
val bytesCopied = copyStreamToAnother(inputStream, FileOutputStream(destFileSafe))
if (bytesCopied == 0L) {
throw IOException("No data was copied to the destination file")
}
}

if (convertVirtualFileAsType == null) {
context.contentResolver.openInputStream(from).use(copyStreamToFile)
copyStreamToFile(context.contentResolver.openInputStream(from))
} else {
getInputStreamForVirtualFile(context.contentResolver, from, convertVirtualFileAsType)
.use(copyStreamToFile)
copyStreamToFile(getInputStreamForVirtualFile(context.contentResolver, from, convertVirtualFileAsType))
}

return destFileSafe
Expand All @@ -161,9 +157,7 @@ class FileOperations(private val uriMap: MutableMap<String, Uri>) {
}

fun writeDocumentImpl(sourceUri: Uri?, targetUriString: String?, context: ReactApplicationContext): DocumentMetadataBuilder {
if (sourceUri == null) {
throw IllegalArgumentException("The source URI is null. Call saveDocument() before writeDocument()")
}
sourceUri ?: throw IllegalArgumentException("The source URI is null. Call saveDocument() before writeDocument()")
val targetUri: Uri? = uriMap[targetUriString]

if (targetUri == null) {
Expand All @@ -180,25 +174,30 @@ class FileOperations(private val uriMap: MutableMap<String, Uri>) {
val mimeFromUri = contentResolver.getType(targetUri)
metadataBuilder.mimeType(mimeFromUri)

// TODO https://gist.github.com/vonovak/73affb1a5b904ee165d9b5981d8dfe9a
contentResolver.openInputStream(sourceUri).use { inputStream ->
if (inputStream == null) {
metadataBuilder.metadataReadingError("No output stream found for source file")
} else {
contentResolver.openOutputStream(targetUri).use { outputStream ->
if (outputStream == null) {
metadataBuilder.metadataReadingError("No output stream found for destination file")
} else {
val bytesCopied = inputStream.copyTo(outputStream)
if (bytesCopied == 0L) {
metadataBuilder.metadataReadingError("No data was copied to the destination file")
}
outputStream.flush()
}
}
}
val inputStream = contentResolver.openInputStream(sourceUri)
?: return metadataBuilder.metadataReadingError("No input stream found for source file")

val outputStream = contentResolver.openOutputStream(targetUri)
?: return metadataBuilder.metadataReadingError("No output stream found for destination file")

val bytesCopied = copyStreamToAnother(inputStream, outputStream)
if (bytesCopied == 0L) {
metadataBuilder.metadataReadingError("No data was copied to the destination file")
}

return metadataBuilder
}

val copyStreamToAnother: (InputStream, OutputStream) -> Long = { inputStream, outputStream ->
inputStream.use { input ->
outputStream.use { output ->
val bytesCopied = if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.Q) {
FileUtils.copy(inputStream, outputStream)
} else {
inputStream.copyTo(outputStream)
}
return@use bytesCopied
}
}
}
}
Loading