-
-
Notifications
You must be signed in to change notification settings - Fork 464
added android support #7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…rl, size and content-type
|
If the way of returning data changed can you update the readme too ? Didn't have time to test yet |
|
I implemented a similar module for android, came here to do a PR but I see there is one already. |
|
Ok, I'll update it to work with rn 0.33 and update the docs. Maybe later today if I get time - thanks for checking it. |
|
@vonovak What did you mean:
You you explain a bit more? |
|
I added you as contributor as I don't have time at all to double check! Thanks again. I'll maybe have to update the npm still though, will check. |
|
Ok, thanks. I'll merge it tomorrow. |
|
@npomfret so what I do is that I have a file selector same as the one you implemented and later I'm using the uri to download the file (if it is a remote file) busing Also, what would be nice is implement the android permissions in the js part of the module. There is a module in core for this as of 0.33. just do |
|
I've merged to master - let incorporate your ideas before pushing a release. Did you mean something like this: |
No description provided.