add detox #155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

luancurti merged 8 commits into master from @vonovak/detox

May 21, 2020

Member

vonovak commented Apr 27, 2020 •

edited

Loading

Summary

this adds e2e tests for android and ios using detox, running in CircleCI, including video recordings and logs! 🎉

Test Plan

tests pass 😄

Compatibility

OS	Implemented
iOS	✅
Android	✅

Checklist

I have tested this on a device and a simulator
I added the documentation in README.md
I mentioned this change in CHANGELOG.md
I updated the typed files (TS and Flow)
I added a sample use of the API in the example project (example/App.js)

vonovak force-pushed the @vonovak/detox branch 15 times, most recently from 3188917 to 659505c Compare

April 29, 2020 13:10

This was referenced May 7, 2020

fix: fix path to emulator react-native-community/react-native-circleci-orb#60

Merged

fix: fix JAVA_HOME path react-native-community/react-native-circleci-orb#61

Merged

Emulator does not run react-native-community/react-native-circleci-orb#53

Closed

feat: follow emulator best practices react-native-community/react-native-circleci-orb#62

Merged

vonovak added 4 commits

May 17, 2020 18:55


          add detox

9601bd7

try android

again

use circus, not headless

use hermes with e2e

test hermes is used

verbose

add missing await

use android 28


          use latest deps

bdb3307


          use latest orb

795b4ec


          test fix to orb

37a7a0b

vonovak force-pushed the @vonovak/detox branch 2 times, most recently from 61cfbfb to 6858ecc Compare

May 17, 2020 18:47


          use plain yarn

970562a

vonovak force-pushed the @vonovak/detox branch from 6858ecc to 970562a Compare

May 17, 2020 18:56

vonovak added 3 commits

May 17, 2020 21:42


          remove skin

559575f


          use latest orb

3ac247f


          upgrade deps

1c883c6

vonovak requested a review from luancurti

May 20, 2020 17:38

vonovak marked this pull request as ready for review

May 20, 2020 17:38

luancurti reviewed

View reviewed changes

example/e2e/init.js Show resolved Hide resolved

luancurti reviewed

View reviewed changes

example/e2e/detoxTest.spec.js Show resolved Hide resolved

luancurti reviewed

View reviewed changes

example/e2e/detoxTest.spec.js Show resolved Hide resolved

luancurti reviewed

View reviewed changes

example/e2e/detoxTest.spec.js Show resolved Hide resolved

luancurti reviewed

View reviewed changes

example/e2e/detoxTest.spec.js Show resolved Hide resolved

luancurti reviewed

View reviewed changes

example/e2e/detoxTest.spec.js Show resolved Hide resolved

luancurti reviewed

View reviewed changes

example/e2e/detoxTest.spec.js Show resolved Hide resolved

luancurti approved these changes

View reviewed changes

Member

luancurti left a comment

Great Job! 🎉

luancurti merged commit 4580d06 into master

vonovak deleted the @vonovak/detox branch

May 21, 2020 19:51

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet