Adding XAML Support and Upgrading to TurboModule for Windows #1025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
November 17, 2025 12:21
- Implement DatePicker TurboModule with promise-based API - Implement TimePicker TurboModule with promise-based API - Add JavaScript wrapper (DateTimePickerWindows) for imperative API - Add TurboModule specs matching Android pattern - Register TurboModules via AddAttributedModules() - Update documentation with TurboModule usage examples - Export DateTimePickerWindows from main index.js This provides feature parity with Android's imperative DateTimePickerAndroid.open() API.
protikbiswas100
changed the title
added 3 commits
November 17, 2025 14:57
- Fix circular import in DateTimePickerWindows.js (was importing from itself instead of .windows file) - Change TurboModuleRegistry.getEnforcing() to get() for Windows specs to handle test environments - Update Jest snapshot to include DateTimePickerWindows export All tests now passing (22/22)
- Created TimePickerFabric.cpp/h implementing ContentIslandComponentView - Registered RNTimePickerWindows as Fabric component - Fixed DateTimePickerWindows.open() to return promise result - Updated ReactPackageProvider to register TimePicker Fabric component - Added TimePickerFabric files to vcxproj build configuration This enables XAML TimePicker control to work with React Native's new architecture (Fabric) on Windows platform.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Test Plan
Created a sample DateTimePicker app to demonstrate usage, ran the app using
yarn react-native run-windows --arch x64build.mp4
What's required for testing (prerequisites)? NA
What are the steps to reproduce (after prerequisites)? NA
Compatibility
Checklist
README.mdexample/App.js)