Skip to content

Conversation

@anthonymayer
Copy link

BREAKING CHANGE: cimg/node doesn't support major Node version aliases the same way circleci/node did

BREAKING CHANGE: cimg/node doesn't support major Node version aliases the same way circleci/node did
@anthonymayer
Copy link
Author

@cortinico is there a way I can test this? I think this should be correct now, but I'd like to make sure and I couldn't find any testing or contribution guidelines

@cortinico
Copy link
Member

is there a way I can test this?

Not sure. Maybe @matt-oakes can tell more

@anthonymayer
Copy link
Author

@cortinico it's probably just easiest to merge then and if the pipeline passes it should be fine. Up to though. Thanks for your help!

@cortinico cortinico merged commit c2a7613 into react-native-community:master Apr 24, 2022
@cortinico
Copy link
Member

@cortinico it's probably just easiest to merge then and if the pipeline passes it should be fine. Up to though. Thanks for your help!

Not sure what's going on, but now it dies with:

Yarn requires Node.js 4.0 or higher to be installed.

Which is really odd as we're running on Node 12 (at least the image tag is correct). Maybe you can test this on your local fork + your CircleCI instance?

@anthonymayer
Copy link
Author

Yes, that's really strange.

Maybe you can test this on your local fork + your CircleCI instance?

@cortinico I'm happy to, but I'm not really sure how. Do I have to publish it as a new orb in my organization or is there a way I can run directly against the git repo? I haven't been able to find any directions for how to do that. Sorry, I'm new to orb development so if there's any info you can point me at, I would appreciate it!

@cortinico
Copy link
Member

Do I have to publish it as a new orb in my organization or is there a way I can run directly against the git repo? I haven't been able to find any directions for how to do that

You won't need to create orbs at all. You just need to setup CircleCI so that this link works:
https://app.circleci.com/pipelines/github/nxt-insurance/react-native-circleci-orb

Once that is done, your fork will run publish workflow on all the pushes. You should then be able to debug this

@react-native-community-bot
Copy link
Collaborator

🎉 This PR is included in version 7.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants