Skip to content

feat: allow passing executor parameters to test jobs #141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 15, 2022
Merged

feat: allow passing executor parameters to test jobs #141

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions src/jobs/android_test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
description: Tests the Android app on the given device, with the given Detox configuration. You should have already built the correct Android APK (including the androidTest APK) and have both persisted to the worksapce.

executor: macos

parameters:
# For this job
workspace_root:
Expand Down Expand Up @@ -76,6 +74,19 @@ parameters:
description: Should we run brew update? Defaults to true
type: boolean
default: true
xcode_version:
description: The version of Xcode to use. See here for the list of supported versions https://circleci.com/docs/2.0/testing-ios/#supported-xcode-versions
type: string
default: "12.4.0"
resource_class:
description: Changes the resource class of the executor. Requires a support request to enable the resource_class parameter. See https://circleci.com/docs/2.0/configuration-reference/#resource_class
type: string
default: medium

executor:
name: macos
xcode_version: <<parameters.xcode_version>>
resource_class: <<parameters.resource_class>>

steps:
- attach_workspace:
Expand Down
15 changes: 13 additions & 2 deletions src/jobs/ios_build_and_test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
description: Builds the iOS app at the given path with the given build scheme and configuration and then runs the tests with the Detox configuration given.

executor: macos

parameters:
# For this job
checkout:
Expand Down Expand Up @@ -95,6 +93,19 @@ parameters:
description: Should we run brew update? Defaults to true
type: boolean
default: true
xcode_version:
description: The version of Xcode to use. See here for the list of supported versions https://circleci.com/docs/2.0/testing-ios/#supported-xcode-versions
type: string
default: "12.4.0"
resource_class:
description: Changes the resource class of the executor. Requires a support request to enable the resource_class parameter. See https://circleci.com/docs/2.0/configuration-reference/#resource_class
type: string
default: medium

executor:
name: macos
xcode_version: <<parameters.xcode_version>>
resource_class: <<parameters.resource_class>>

steps:
- when:
Expand Down