Setting node_version is ignored at ios_build_and_test

[MateusAndrade]

Orb version

4.1.0

What happened

Whenever I use the job ios_build_and_test:

      - react-native/ios_build_and_test:
          checkout: true
          build_configuration: Release
          detox_configuration: ios.sim.release
          device: iPhone X
          node_version: '10.17'
          project_path: ios/AppName.xcworkspace
          requires:
            - another-command
          scheme: AppName

When the job runs

react-native-circleci-orb/src/jobs/ios_build_and_test.yml

Line 85 in a9ca7c9

- yarn_install

I got an error, because of a dependency on my project, requires using the node_version < 10.17.

I saw that whenever you call:

react-native-circleci-orb/src/commands/setup_macos_executor.yml

Lines 25 to 37 in a9ca7c9

	- run:
	name: Install node@<<parameters.node_version>>
	# after `curl`, bashrc contains the script to load nvm, we need to source it to use it
	command: |
	set +e
	curl -o- https://raw.githubusercontent.com/creationix/nvm/v0.35.3/install.sh | bash
	source ~/.bashrc
	command -v nvm
	nvm install <<parameters.node_version>>
	nvm alias default <<parameters.node_version>>
	- run:
	name: Verify node version
	command: node --version

He will fetch nvm and set the version on macos 11.0.0 executor. But on the subsequent job, that shows the node -v, you still got the default version of the macos executor. With is: 12.0.

https://circle-macos-docs.s3.amazonaws.com/image-manifest/v1969/index.html

Expected behavior

Calling yarn_install passing node_version at ios_build_and_test would save the version to subsequent jobs.

Maybe we can add a parameter to check if I want a specific version of node when calling yarn_install.

ScreenShots

[matt-oakes]

👋 Just to check that I understand this correctly: Are you saying that initially the node version is set and installed correctly, but in any step after that it's reverting back to the default version?

[MateusAndrade]

👋 Just to check that I understand this correctly: Are you saying that initially the node version is set and installed correctly, but in any step after that, it's reverting back to the default version?

I have a dependency on my project that requires the node version to be: 10 < 10.17. However, the default image of CircleCI for MacOS which this orb uses is using node 12. So, any time this orbs call yarn_install this throw an error regarding this version.

I checked the command setup_macos_executor, and found that even passing node_version this still using the default version installed.

On my case, adding a way to override the version of node on yarn_install would solve my issue(see #52),. But I think the behavior of setup_macos_executor is wrong.

Also, my description was confusing, sorry for that. 😅

[vonovak]

I think I have messed this up in https://github.com/react-native-community/react-native-circleci-orb/pull/47/files

I was not aware that node version would not persists across build steps; granted, I'm not a circle expert.
@MateusAndrade can you confirm that if node version is persisted, it will fix your problem and you will not need #52 ? Thanks!

[MateusAndrade]

@MateusAndrade can you confirm that if node version is persisted, it will fix your problem and you will not need #52 ? Thanks!

Sure! I miss things on CircleCI every time HAHAHA. I need to test my changes to ensure this is working, also do you know any way to properly test these changes? I think I will need to override the commands on my CI using my changes to ensure this is working.

[vonovak]

@MateusAndrade regarding testing the changes, I think you can use circleci config pack - that will spit out a (huge) yaml that you can just copy paste to your config and edit it there, inline. I didn't find anything better.

[MateusAndrade]

@MateusAndrade regarding testing the changes, I think you can use circleci config pack - that will spit out a (huge) yaml that you can just copy paste to your config and edit it there, inline. I didn't find anything better.

Yeah, I was using this command to test these changes but I don't pushed the changes to CircleCI to ensure it's working. I will give a proper look at that and let you know more about it. 😄

[matt-oakes]

@MateusAndrade The node version should be managed by NVM. The issue seems to be that NVM is not being loaded correctly in each step. The PR you've opened is a workaround, but not a proper fix for that.

Using the information here I've just released a new version of the Orb which should fix the issue. Can you install and use 4.1.1 and let me know if that fixes this issue for you?

[MateusAndrade]

@matt-oakes thanks! I'm testing this version right now. 🎉

Edit:

Tested here with 4.1.1 and the version of node is updated according to node_version before calling setup_macos_executor. 👯 👯 👯

Thanks for the help @matt-oakes , @vonovak !