Update default version to node 10 or 12?

[Naturalclar]

What would you like to be added

Currently, the default value of node version is 8.
I'd like to suggest to upgrade the default version to 10 or 12.

Why is this needed

Node version 8 has reached its EOL in 2020.

https://nodejs.org/en/about/releases/

[roni-castro]

Thanks for the information @Naturalclar. Currently on the project we have node version 8 being declared in four places. I will try to update them soon in my testing Orb project of this repo and check which version will not be a breaking change and if not possible, add some parameter to allow the user change it to a specific one.

Here are the places we use specific version of node (Highlighted in yellow):

https://github.com/react-native-community/react-native-circleci-orb/blame/83e9c2ed3b5cf0c15422f5b701cef4dc315d926f/.circleci/config.yml#L24

https://github.com/react-native-community/react-native-circleci-orb/blame/7c5b51a6c2752ed9f0975a24b5bd86764f178d72/src/commands/setup_macos_executor.yml#L7

https://github.com/react-native-community/react-native-circleci-orb/blame/7c5b51a6c2752ed9f0975a24b5bd86764f178d72/src/commands/setup_macos_executor.yml#L24

https://github.com/react-native-community/react-native-circleci-orb/blame/9dff062b55dd60327825ea04429a383d8b37cace/src/executors/linux_js.yml#L5

[safaiyeh]

Thanks for the issue @Naturalclar.

Yeah I just upgraded to v8.0.0 of @semantic-release/git and they dropped Node v8 support. Came here to create and issue as well. Thanks for looking into it @roni-castro

[matt-oakes]

Thanks for looking into this @roni-castro. Feel free to open a PR with the changes when you're ready.

[roni-castro]

I have made the updates by adding parameters and setting node to the latest value and it worked on one of my projects, but I still need to run the macos build and tests on another project, soon I will open a PR.
What do you think it is better, to fix a node version or always use the latest one?

  node_version:
    type: string
    default: 'latest'

or

  node_version:
    type: string
    default: '12'

[safaiyeh]

Latest as in v13.6.0?

I would like an option latest LTS version.

[Naturalclar]

Thanks for working on this!

I'd also prefer lts over latest being the default

[lfalkner]

Several libraries in RN do not support node 12 yet, it may be wiser to approach with 10 as a default, and document usage for overriding the node_version for the rn/linux_js executor.

For example, i've tried using the latest of this orb, and this configuration fails circleci config validate

executors:
  rn/linux_js:
    node_version: "10.16.0"

[roni-castro]

Brew, used on setup_macos_executor, does not have lts version. I have tried using node version 12, but for some reason this version was not found and generated an error on CI, when trying to install it with brew (image below), even though brew install node@12 works on my local machine and exists according to the docs.

So I will update it to version 10 which worked in all my projects and allow to change this version through parameters. If someone is interested in testing on your project this is the Orb: roni-castro/react-native-circleci-orb@2.1.1.
PR: #37 .

Error message with node 12:

[lfalkner]

@roni-castro I'm seeing the same issue with your forked orb as with the latest release, I'm getting a corrupted tarball from yarn / npm. The "best" solution we've come across, and what I've seen suggested is to pass the network concurrency flag to yarn install. Otherwise, any packages that have prepare included in their package.json will trigger a build within the yarn install command, which . can corrupt the cache, so it leads to intermittent build failures.
yarn install --network-concurrency 1
related issue with yarn

[roni-castro]

@roni-castro I'm seeing the same issue with your forked orb as with the latest release, I'm getting a corrupted tarball from yarn / npm. The "best" solution we've come across, and what I've seen suggested is to pass the network concurrency flag to yarn install. Otherwise, any packages that have prepare included in their package.json will trigger a build within the yarn install command, which . can corrupt the cache, so it leads to intermittent build failures.
yarn install --network-concurrency 1
related issue with yarn

Hi @lfalkner, thanks for the information, but I think this problem is not related with the node update, as the latest version of this repo uses node 8.
Please, open another issue with more details, the error message and your suggestion, and if possible, please try downgrading the version to 1.5.0 and/or 1.4.0 of this repo to see if this problem also occurs.

[lfalkner]

Hi @roni-castro thank you, I apologize for the confusion. This problem is not related to the node update, but it does block me from using the containers, unfortunately. Because we have some modules which require yarn to run a prepare step, we cannot use yarn install as-is on your containers. :( If I have time later on this week, I can try exposing the parameters to the yarn install command you've written as environment variables, and try testing again. Thanks!

[react-native-community-bot]

🎉 This issue has been resolved in version 3.0.0 🎉

The release is available on:

• CircleCI Orb
• GitHub release

Your semantic-release bot 📦🚀