Skip to content

Conversation

krizzu
Copy link
Member

@krizzu krizzu commented Jul 5, 2024

Summary

Migrating to changeset as keeping up with semantic-release for monorepo can become cumbersome

@krizzu krizzu requested a review from tido64 as a code owner July 5, 2024 11:55
Copy link

changeset-bot bot commented Jul 5, 2024

⚠️ No Changeset found

Latest commit: a83aa28

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@krizzu krizzu enabled auto-merge (squash) July 5, 2024 11:56
Copy link
Member

@tido64 tido64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changesets is great. LGTM 🚀

"access": "public",
"baseBranch": "main",
"updateInternalDependencies": "patch",
"ignore": []
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to ignore eslint-config and website?

Suggested change
"ignore": []
"ignore": [
"@react-native-async-storage/eslint-config",
"async-storage-website"
]

},
"devDependencies": {
"@changesets/cli": "^2.27.7",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also add @changesets/changelog-github since we're referencing it in the config?

Suggested change
"@changesets/cli": "^2.27.7",
"@changesets/changelog-github": "^0.5.0",
"@changesets/cli": "^2.27.7",

@@ -2205,6 +2205,15 @@ __metadata:
languageName: node
linkType: hard

"@babel/runtime@npm:^7.20.1, @babel/runtime@npm:^7.5.5":
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This entry should be deduped.

@krizzu krizzu merged commit 470f73e into main Jul 11, 2024
@krizzu krizzu deleted the chore/migrate-to-changeset branch July 11, 2024 03:16
r0h0gg6 pushed a commit to r0h0gg6/async-storage that referenced this pull request Jul 28, 2025
* remove semantic release

* changeset setup

* release gh action
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants