Skip to content

chore: back of missing preview.rootClassName #384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 17, 2025
Merged

chore: back of missing preview.rootClassName #384

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/Image.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,6 +119,7 @@ const ImageInternal: CompoundedComponent<ImageProps> = props => {
cover,
classNames: previewClassNames = {},
styles: previewStyles = {},
rootClassName: previewRootClassName,
...restProps
}: PreviewConfig = preview && typeof preview === 'object' ? preview : {};

Expand Down Expand Up @@ -262,7 +263,7 @@ const ImageInternal: CompoundedComponent<ImageProps> = props => {
imgCommonProps={imgCommonProps}
classNames={previewClassNames}
styles={previewStyles}
rootClassName={rootClassName}
rootClassName={classnames(previewRootClassName, rootClassName)}
{...restProps}
/>
)}
Expand Down
3 changes: 2 additions & 1 deletion src/Preview/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,8 @@ export type ToolbarRenderInfoType = {

export interface InternalPreviewConfig {
// Semantic
/** Better to use `classNames.root` instead */
rootClassName?: string;
classNames?: Partial<Record<InternalPreviewSemanticName, string>>;
styles?: Partial<Record<InternalPreviewSemanticName, React.CSSProperties>>;

Expand Down Expand Up @@ -108,7 +110,6 @@ export interface InternalPreviewConfig {
export interface PreviewProps extends InternalPreviewConfig {
// Misc
prefixCls: string;
rootClassName?: string;

// Origin image Info
imageInfo?: {
Expand Down
17 changes: 16 additions & 1 deletion tests/preview.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -643,7 +643,7 @@ describe('Preview', () => {

it('Customize preview props', () => {
const src = 'https://zos.alipayobjects.com/rmsportal/jkjgkEfvpUPVyRjUImniVslZfWPnJuuZ.png';
const { container } = render(
render(
<Image
src={src}
preview={{
Expand Down Expand Up @@ -712,6 +712,21 @@ describe('Preview', () => {
expect(document.querySelectorAll('.custom-className')).toHaveLength(2);
});

it('preview.rootClassName should be correct', () => {
const src = 'https://zos.alipayobjects.com/rmsportal/jkjgkEfvpUPVyRjUImniVslZfWPnJuuZ.png';
render(
<Image
src={src}
preview={{
open: true,
rootClassName: 'custom-className',
}}
/>,
);

expect(document.querySelector('.rc-image-preview.custom-className')).toBeTruthy();
});

it('if async src set should be correct', () => {
const src =
'https://gw.alipayobjects.com/mdn/rms_08e378/afts/img/A*P0S-QIRUbsUAAAAAAAAAAABkARQnAQ';
Expand Down