Conditional compilation of PLATFORM_DESKTOP segments should also apply to PLATFORM_DESKTOP_LINUX segments #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y to PLATFORM_DESKTOP_LINUX segments.
raysan5
pushed a commit
that referenced
this pull request
Sep 22, 2018
Linux Support for VSCode Project
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While checking the correctness of my last pull request, I had a version of libraysan.a compiled using
-DPLATFORM_DESKTOP, which turned out to build correctly every example. However, I failed to notice that using-DPLATFORM_DESKTOP_LINUXexcludes several raylib functions from the library. This pull request should fix that.As a matter of style, I'm beginning to feel that preprocessing directives such as
are starting to get a bit unwieldy, but I'm sticking to the overall coding style of libraysan. Maybe a shared
PLATFORM_DESKTOPdefinition and separateDESKTOP_WINDOWSandDESKTOP_LINUXdefinitions would turn out to be more readable, but then again, maybe not.Cheers!