[platform_desktop] fixed issue with GetScreenWidth/GetScreenHeight #4074
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
@CrackedPixel thanks for the review. At first sight it seems logical, wondering why those lines were not there... 🤔 |
manuel5975p
pushed a commit
to manuel5975p/raylib
that referenced
this pull request
Jun 19, 2024
This was referenced Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a known issue that people are having where
GetScreenWidth/GetScreenHeightare returning incorrect values. It only uses the one set during initialization and does not work if you change the screen size. I believe this section of code is missing, and I copied the format fromSetWindowMaxSizedirectly above itPLATFORM_DEKSTOP_SDLdoes the same thing: https://github.com/raysan5/raylib/blob/master/src/platforms/rcore_desktop_sdl.c#L661Note: I don't know about
CORE.Window.render.width/height or where that one should be added (definitely a separate PR) but it has the same problem and i believe same solution#3763
#3764