-
Notifications
You must be signed in to change notification settings - Fork 6.9k
Closed
Description
Once format.sh has been updated to support the Black code style (#21312) and we've preemptively fixed as many Black-related issues as possible (#21313, #21314, #21315), we can actually format the Python code with Black. Here's how we can achieve that:
- Set the
BLACK_FORMATTER_ENABLEDflag totrueinformat.sh(see [CI] Updateformat.shto support the Black code style #21312) - Run
./scripts/format.sh - Add
noqacomments on lines that are too long.
python/ray/_private/function_manager.py:218:89: E501 line too long (89 > 88 characters)
python/ray/actor.py:1219:89: E501 line too long (103 > 88 characters)
python/ray/autoscaler/_private/updater.py:420:89: E501 line too long (90 > 88 characters)
python/ray/node.py:1016:89: E501 line too long (115 > 88 characters)
python/ray/serve/api.py:251:89: E501 line too long (90 > 88 characters)
python/ray/state.py:365:89: E501 line too long (108 > 88 characters)
python/ray/tests/aws/utils/stubs.py:24:89: E501 line too long (98 > 88 characters)
python/ray/tests/test_autoscaler_yaml.py:484:89: E501 line too long (97 > 88 characters)
python/ray/util/client/server/dataservicer.py:65:89: E501 line too long (90 > 88 characters)
release/alert.py:159:89: E501 line too long (109 > 88 characters)
rllib/examples/env/coin_game_vectorized_env.py:176:89: E501 line too long (92 > 88 characters)
rllib/policy/tf_policy.py:564:89: E501 line too long (89 > 88 characters)
rllib/policy/torch_policy.py:1036:89: E501 line too long (89 > 88 characters)
- Manually move
noqacomments that have been moved out of place.
python/ray/serve/tests/test_fastapi.py:585:9: F811 redefinition of unused 'method' from line 581
python/ray/train/examples/transformers/transformers_example.py:404:40: E741 ambiguous variable name 'l'
python/ray/tune/logger.py:739:1: E402 module level import not at top of file
python/ray/tune/utils/util.py:20:1: F401 'ray.util.ml_utils.dict.merge_dicts' imported but unused
python/ray/tune/utils/util.py:20:1: F401 'ray.util.ml_utils.dict.deep_update' imported but unused
python/ray/tune/utils/util.py:20:1: F401 'ray.util.ml_utils.dict.flatten_dict' imported but unused
python/ray/tune/utils/util.py:20:1: F401 'ray.util.ml_utils.dict.unflatten_dict' imported but unused
python/ray/tune/utils/util.py:20:1: F401 'ray.util.ml_utils.dict.unflatten_list_dict' imported but unused
python/ray/tune/utils/util.py:20:1: F401 'ray.util.ml_utils.dict.unflattened_lookup' imported but unused
rllib/execution/common.py:7:1: F401 'ray.rllib.utils.metrics.LAST_TARGET_UPDATE_TS' imported but unused
rllib/execution/common.py:7:1: F401 'ray.rllib.utils.metrics.NUM_TARGET_UPDATES' imported but unused
rllib/execution/common.py:7:1: F401 'ray.rllib.utils.metrics.APPLY_GRADS_TIMER' imported but unused
rllib/execution/common.py:7:1: F401 'ray.rllib.utils.metrics.COMPUTE_GRADS_TIMER' imported but unused
rllib/execution/common.py:7:1: F401 'ray.rllib.utils.metrics.WORKER_UPDATE_TIMER' imported but unused
rllib/execution/common.py:7:1: F401 'ray.rllib.utils.metrics.GRAD_WAIT_TIMER' imported but unused
rllib/execution/common.py:7:1: F401 'ray.rllib.utils.metrics.SAMPLE_TIMER' imported but unused
rllib/execution/common.py:7:1: F401 'ray.rllib.utils.metrics.LEARN_ON_BATCH_TIMER' imported but unused
rllib/execution/common.py:7:1: F401 'ray.rllib.utils.metrics.LOAD_BATCH_TIMER' imported but unused
Metadata
Metadata
Assignees
Labels
No labels