Skip to content

Conversation

ChrisCindy
Copy link
Contributor

@ChrisCindy ChrisCindy commented Apr 22, 2022

  • use @ice/pkg to transform pwc files
  • use @ice/pkg to bundle pwc files
  • add babel config into @ice/pkg
  • support preview projects in dev mode
  • update jest config to support esm

@codecov-commenter
Copy link

codecov-commenter commented May 9, 2022

Codecov Report

Merging #61 (99e0b68) into main (6eddb4f) will increase coverage by 2.32%.
The diff coverage is 100.00%.

❗ Current head 99e0b68 differs from pull request most recent head a1d5ca5. Consider uploading reports for the commit a1d5ca5 to get more accurate results

@@            Coverage Diff             @@
##             main      #61      +/-   ##
==========================================
+ Coverage   87.29%   89.62%   +2.32%     
==========================================
  Files          45       45              
  Lines         921      896      -25     
  Branches      204      211       +7     
==========================================
- Hits          804      803       -1     
+ Misses        117       92      -25     
- Partials        0        1       +1     
Impacted Files Coverage Δ
packages/pwc-compiler/src/compileStyle.ts 0.00% <ø> (ø)
packages/pwc-compiler/src/compileTemplate.ts 100.00% <ø> (+4.22%) ⬆️
...kages/pwc-compiler/src/compileTemplateInRuntime.ts 94.44% <ø> (+94.44%) ⬆️
packages/pwc-compiler/src/parse.ts 90.80% <ø> (-1.25%) ⬇️
packages/pwc-compiler/src/transform/index.ts 100.00% <ø> (ø)
packages/pwc-compiler/src/compileScript.ts 100.00% <100.00%> (ø)
...ages/pwc-compiler/src/transform/autoAddAccessor.ts 100.00% <100.00%> (ø)
...ler/src/transform/autoAddCustomElementDecorator.ts 100.00% <100.00%> (ø)
...compiler/src/transform/autoAddReactiveDecorator.ts 98.11% <100.00%> (-0.11%) ⬇️
.../pwc-compiler/src/transform/autoInjectImportPWC.ts 100.00% <100.00%> (ø)
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6eddb4f...a1d5ca5. Read the comment docs.

@ChrisCindy ChrisCindy changed the title [WIP] Feat/access ice pkg Feat/access ice pkg May 9, 2022
@@ -1,3 +1,4 @@
import { jest } from '@jest/globals';
import '../native/HTMLElement';

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

injectGlobals 这个配置默认是 true 吧?需要 import @jest/globals 吗?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SoloJiang
SoloJiang previously approved these changes May 11, 2022
@ChrisCindy ChrisCindy requested review from cryzzchen and SoloJiang May 11, 2022 07:14
@ChrisCindy ChrisCindy merged commit 4ccdec1 into main May 13, 2022
@delete-merged-branch delete-merged-branch bot deleted the feat/access-ice-pkg branch May 13, 2022 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants