Add board file for Pi-Plates MICROPi #1487
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MICROpi board file for pico-sdk
peterharperuk
previously requested changes
Jan 12, 2024
Contributor
peterharperuk
left a comment
peterharperuk
left a comment
There was a problem hiding this comment.
You need to push this to the development branch, not master.
lurch
reviewed
Jan 12, 2024
kilograham
previously approved these changes
May 19, 2024
Contributor
|
With the following small tweaks, this passes the checks I added in #1724
// Board definition for the Pi-Plates MICROPi processor board
-#ifndef _BOARDS_PIPLATES_MICROPI_H_RP2040
-#define _BOARDS_PIPLATES_MICROPI_H_RP2040
+#ifndef _BOARDS_PI_PLATES_MICROPI_H
+#define _BOARDS_PI_PLATES_MICROPI_H
// For board detection
-#define PIPLATES_MICROPI_RP2040
+#define PI_PLATES_MICROPI
// --- UART ---
#ifndef PICO_DEFAULT_UART |
Contributor
|
this was added as part of #1724 |
Contributor
Umm, no it wasn't. |
Contributor
|
is it ready to merge? |
Contributor
|
IMHO it'll be ready to merge if the changes I suggested earlier are made, i.e.
// Board definition for the Pi-Plates MICROPi processor board
-#ifndef _BOARDS_PIPLATES_MICROPI_H_RP2040
-#define _BOARDS_PIPLATES_MICROPI_H_RP2040
+#ifndef _BOARDS_PI_PLATES_MICROPI_H
+#define _BOARDS_PI_PLATES_MICROPI_H
// For board detection
-#define PIPLATES_MICROPI_RP2040
+#define PI_PLATES_MICROPI
// --- UART ---
#ifndef PICO_DEFAULT_UARTAre you able to do that @pi-plates or should I just close this PR and create a new one? (Apologies for not making this clear in my previous comment.) |
Contributor
Author
|
Im on VACA and will do this when I get back. I might need a little hand
holding though...
…On Tue, Jun 25, 2024, 1:23 PM Andrew Scheller ***@***.***> wrote:
IMHO it'll be ready to merge if the changes I suggested earlier are made,
i.e.
// Board definition for the Pi-Plates MICROPi processor board
-#ifndef _BOARDS_PIPLATES_MICROPI_H_RP2040-#define _BOARDS_PIPLATES_MICROPI_H_RP2040+#ifndef _BOARDS_PI_PLATES_MICROPI_H+#define _BOARDS_PI_PLATES_MICROPI_H
// For board detection-#define PIPLATES_MICROPI_RP2040+#define PI_PLATES_MICROPI
// --- UART ---
#ifndef PICO_DEFAULT_UART
Are you able to do that @pi-plates <https://github.com/pi-plates> or
should I just close this PR and create a new one? (Apologies for not making
this clear in my previous comment.)
—
Reply to this email directly, view it on GitHub
<#1487 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACACCAOCOOBRI3DN6327N6TZJGYSLAVCNFSM6AAAAAA4BJM6RGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOBZGY3TSMBWGE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Slight tweak to some of the #define-names
Contributor
|
I've now made the above-mentioned changes directly. |
lurch
approved these changes
Jul 24, 2024
Contributor
lurch
left a comment
lurch
left a comment
There was a problem hiding this comment.
tools/check_board_header.py is happy, so approving
Contributor
Author
|
Thanks a lot.
Jerry Wasinger
Founder, Pi-Plates
…On Wed, Jul 24, 2024 at 5:47 AM Andrew Scheller ***@***.***> wrote:
I've now made the above-mentioned changes directly.
—
Reply to this email directly, view it on GitHub
<#1487 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACACCAMFTPLSGU6JF6PFA2TZN5Z3FAVCNFSM6AAAAAA4BJM6RGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENBXGQYTSNZXGM>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MICROpi board file for pico-sdk