Various small fixes towards building with other compilers #1285
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
kilograham
commented
Feb 27, 2023
kilograham
commented
- Fix various non-GCC warnings (no effect on GCC)
- Reduce use of typeof since non GCC compilers may not support it
- Introduce PICO_C_COMPILER_IS_GNU, PICO_C_COMPILER_IS_CLANG, PICO_C_COMPILER_IS_IAR to CMake as if (CMAKE_C_COMPILER_ID STREQUAL "xxx") is a bit verbose
- Use "unified_asm" macro for all inline asm (it is "volatile __asm" on GNU with a .syntex unified)
- Use NOLOAD instead of COPY in linker scripts (arguably more correct anyway)
- Use the same style for setting _etext in all 4 linker scripts (to the beginning of .data). Clang aligns .data on a 16 byte boundary. Note ideally we'd add a new symbol __data_source, however that would break backwards compatibility with existing user linker scripts
- Use "a" for .stack, .heap sections because clang complains otherwise, and they are explicitly NOLOAD anyway
- Avoid duplicating __sev, __wfe, __wfi which Clang sometimes seems to provide as built-ins
- Add missing kitchen_sink_blocked_ram binary
- Allow build with LLVM Embedded Toolchain Form ARM v 14.0.0 (unsupported atm)
* Fix various non-GCC warnings (no effect on GCC) * Reduce use of typeof since non GCC compilers may not support it * Introduce PICO_C_COMPILER_IS_GNU, PICO_C_COMPILER_IS_CLANG, PICO_C_COMPILER_IS_IAR to CMake as if (CMAKE_C_COMPILER_ID STREQUAL "xxx") is a bit verbose * Use "unified_asm" macro for all inline asm (it is "volatile __asm" on GNU with a .syntex unified) * Use NOLOAD instead of COPY in linker scripts (arguably more correct anyway) * Use the same style for setting _etext in all 4 linker scripts (to the beginning of .data). Clang aligns .data on a 16 byte boundary. Note ideally we'd add a new symbol __data_source, however that would break backwards compatibility with existing user linker scripts * Use "a" for .stack, .heap sections because clang complains otherwise, and they are explicitly NOLOAD anyway * Avoid duplicating __sev, __wfe, __wfi which Clang sometimes seems to provide as built-ins * Add missing kitchen_sink_blocked_ram binary * Allow build with LLVM Embedded Toolchain Form ARM v 14.0.0 (unsupported atm)
Wren6991
reviewed
Mar 1, 2023
| static inline int diszero(double x) { return dgetexp (x)==0; } | ||
| static inline int dispzero(double x) { return dgetsignexp(x)==0; } | ||
| static inline int dismzero(double x) { return dgetsignexp(x)==0x800; } | ||
| //static inline int dispzero(double x) { return dgetsignexp(x)==0; } |
Contributor
There was a problem hiding this comment.
Why are these commented out?
Contributor
Author
There was a problem hiding this comment.
because they are unused - and that causes a warning - i guess i could have deleted them
| if (PICO_C_COMPILER_IS_GNU) | ||
| target_link_options(pico_runtime INTERFACE "--specs=nosys.specs") | ||
| elseif (PICO_C_COMPILER_IS_CLANG) | ||
| # target_link_options(pico_runtime INTERFACE "-nostdlib") |
Contributor
There was a problem hiding this comment.
Why is this commented out?
Contributor
Author
There was a problem hiding this comment.
also not necessary; again i could have deleted i guess
Wren6991
approved these changes
Mar 1, 2023
Contributor
Wren6991
left a comment
Wren6991
left a comment
There was a problem hiding this comment.
Looks ok to me. I did notice some non-volatile asm that became volatile due to the new unified_asm macro but none of it looked worrying.
peterharperuk
approved these changes
Mar 1, 2023
Contributor
peterharperuk
left a comment
peterharperuk
left a comment
There was a problem hiding this comment.
I can't spot any issues.
Contributor
Author
yes, i figured this was harmless |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.