Make sure BT device address is set. #1284
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kilograham
requested changes
Feb 27, 2023
peterharperuk
force-pushed
the
set_bt_mac_if_unset
branch
2 times, most recently
from
2e65424 to
1223772
Compare
kilograham
requested changes
Feb 27, 2023
Contributor
Author
|
I've been testing with Micropython and I notice we set the mac differently if OTP is not set. I've included a change that makes the sdk use the same code as MP to be consitent |
If OTP is not set the sdk generates a different mac to MP. Use the same code to be consistent.
peterharperuk
force-pushed
the
set_bt_mac_if_unset
branch
from
3067c4d to
8fca485
Compare
kilograham
approved these changes
Feb 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some devices seem to not have their OTP set. This is handled for the wifi mac but the BT device address gets set to an always the same default. Always set the bt address to wifi mac + 1
Fixes #1269