Add missing busy_wait_ms functino to host platform #1254
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lurch
reviewed
Feb 13, 2023
| PICO_WEAK_FUNCTION_DEF(busy_wait_ms) | ||
| void PICO_WEAK_FUNCTION_IMPL_NAME(busy_wait_ms)(uint32_t delay_ms) { | ||
| #if defined(__unix__) || defined(__APPLE__) | ||
| usleep(delay_ms * 1000); |
Contributor
There was a problem hiding this comment.
https://man7.org/linux/man-pages/man3/usleep.3.html says that usleep fails if "usec is greater than or equal to 1000000", which I guess means this busy_wait_ms function will fail if passed a delay_ms value >= 1000 ?
Is that something we ought to check for, or are we not really that concerned about the correct operation of "host platform mode"? 🤷♂️
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.