Add some configuration for VBUS / VSYS #1252
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@kilograham Any thoughts on this? |
lurch
reviewed
Feb 14, 2023
lurch
reviewed
Feb 14, 2023
peterharperuk
force-pushed
the
vsys_vbus_config
branch
from
a52778c to
8742245
Compare
lurch
reviewed
Feb 14, 2023
lurch
reviewed
Feb 14, 2023
The process for reading VBUS and VSYS on Pico and Pico W is different. It's hard to write code that compiles for both devices. Add some configuration to the board files. Fixes raspberrypi#1222
peterharperuk
force-pushed
the
vsys_vbus_config
branch
from
8742245 to
e3d8b03
Compare
Contributor
Author
|
@kilograham Does this look ok? I might use this to add some handling to Micropython if it's likely to be merged |
kilograham
approved these changes
Mar 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The process for reading VBUS and VSYS on Pico and Pico W is different. It's hard to write code that compiles for both devices. Add some configuration to the board files.
Fixes #1222