This repository was archived by the owner on Feb 27, 2023. It is now read-only.
Clear partition names better & for USB #461
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After writing a new partition table, multiimagewritethread::run() attempts to erase any old partition information like volume names by erasing the first sector of the partition. However, For an ext4 partition, the volume label is in the Superblock which is located in the 3rd sector, so these are not erased.
This PR erases 3 sectors so that it will clear ext4 and FAT partition volume names.
Also, the additional feature of installing to a USB drive did not take this into account properly and so the boot partitions were not erased in a _multiDrive installation. This is also fixed by this PR.
Fixes the other issue in #456