This repository was archived by the owner on Feb 27, 2023. It is now read-only.
Shorten partition label names according to fstype #460
+84
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Contributor
|
Thanks |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a partition label is specified that is >15 characters in length, NOOBS will unilaterally erase it.
This PR will shorten the partition label to the appropriate size for the file system instead: 11 for FAT, 16 for ext4 and 32 for NTFS. It will then make the label unique if necessary.
The shorten() function tries to make a sensible partition label out of one that has several distinct parts. If this is not required, the call can be replaced by something like
label = label.left(maxLabelLen);Fixes one issue from #456.