Skip to content

Conversation

6by9
Copy link
Contributor

@6by9 6by9 commented Jul 7, 2020

Overlay and defconfig change to enable OV7251.
Requested on https://www.raspberrypi.org/forums/viewtopic.php?f=28&t=277885
I don't have any hardware to test with, but hacking the driver not to try any of the I2C reads, it does probe and register with V4L2 properly.

6by9 added 2 commits July 7, 2020 16:16
Adds an overlay for the OV7251 VGA global shutter sensor.

Signed-off-by: Dave Stevenson <[email protected]>
port {
csi1_ep: endpoint {
remote-endpoint = <&ov7251_0>;
data-lanes = <1>;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of the camera overlays give the csi endpoint a clock-lanes property, while others don't. What's the logic behind the choice?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clock-lanes ought to be there for completeness, but isn't mandatory in our case.
Some SoCs (and a very few sensors) allow reassigning of CSI pair to function, so you might get

clock-lanes = <4>
data-lanes = <0 2 1 3>

if someone had been particularly perverse in their wiring.

Unicam doesn't support reordering, so clock-lane will always be <0> (assumed and never checked), and the only thing that matters in data-lanes is the number of entries. I did put in clock-lane for completeness on a couple of overlays, and probably ought to here too.

The other parameter that might be worth specifying is the bus-type (CSI-2 DPHY vs CCP2 vs parallel, etc). Upstream are moving towards pushing this explicitly into DT instead of deducing it from the other parameters that are specified on the endpoint. I may blitz them all if I get particularly bored.

@6by9 6by9 changed the title WIP: OV7251 overlay and defconfig OV7251 overlay and defconfig Jul 9, 2020
@6by9
Copy link
Contributor Author

6by9 commented Jul 9, 2020

It's been confirmed on https://www.raspberrypi.org/forums/viewtopic.php?f=43&t=277885 that the overlay loads and they can stream images from the sensor, so I'm good with this.

@pelwell pelwell merged commit 291568e into raspberrypi:rpi-5.4.y Jul 9, 2020
popcornmix added a commit to raspberrypi/firmware that referenced this pull request Jul 13, 2020
kernel: vc4_hdmi: Support HBR audio
See: raspberrypi/linux#3717

kernel: OV7251 overlay and defconfig
See: raspberrypi/linux#3714

kernel: Imx290 & unicam v4l2-compliance fixes
See: raspberrypi/linux#3712

kernel: Enhances the DAC+ driver to control the optional headphone amplifier
See: raspberrypi/linux#3711

kernel: OV9281 driver and overlay
See: raspberrypi/linux#3709

kernel: dtoverlays: Fixup imx219 and imx477 overlays due to parsing failures
See: raspberrypi/linux#3706

kernel: FKMS: max refresh rate and blocking 1366x768
See: raspberrypi/linux#3704

kernel: Fix lockups and IRQ jitter on multicore RasPis
See: raspberrypi/linux#3703

kernel: dts: Further simplify firmware clocks
See: raspberrypi/linux#3609

kernel: configs: Add CAN_EMS_USB=m
See: raspberrypi/linux#3716

kernel: configs: Enable CONFIG_BLK_DEV_NVME=m

kernel: ARM: dts: Make bcm2711 dts more like 5.7

firmware: arm_loader: Don't enable the ARM USB IRQ
See: raspberrypi/linux#3703

firmware: hdmi: Remove M2MC/BVB min turbo clock request
popcornmix added a commit to Hexxeh/rpi-firmware that referenced this pull request Jul 13, 2020
kernel: vc4_hdmi: Support HBR audio
See: raspberrypi/linux#3717

kernel: OV7251 overlay and defconfig
See: raspberrypi/linux#3714

kernel: Imx290 & unicam v4l2-compliance fixes
See: raspberrypi/linux#3712

kernel: Enhances the DAC+ driver to control the optional headphone amplifier
See: raspberrypi/linux#3711

kernel: OV9281 driver and overlay
See: raspberrypi/linux#3709

kernel: dtoverlays: Fixup imx219 and imx477 overlays due to parsing failures
See: raspberrypi/linux#3706

kernel: FKMS: max refresh rate and blocking 1366x768
See: raspberrypi/linux#3704

kernel: Fix lockups and IRQ jitter on multicore RasPis
See: raspberrypi/linux#3703

kernel: dts: Further simplify firmware clocks
See: raspberrypi/linux#3609

kernel: configs: Add CAN_EMS_USB=m
See: raspberrypi/linux#3716

kernel: configs: Enable CONFIG_BLK_DEV_NVME=m

kernel: ARM: dts: Make bcm2711 dts more like 5.7

firmware: arm_loader: Don't enable the ARM USB IRQ
See: raspberrypi/linux#3703

firmware: hdmi: Remove M2MC/BVB min turbo clock request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants