Skip to content

Do not update memory storage with a nil secret #205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 15, 2025
Merged

Do not update memory storage with a nil secret #205

merged 1 commit into from
Sep 15, 2025

Conversation

brandond
Copy link
Member

Do not store a nil secret, fixes:

time="2025-09-12T21:03:40Z" level=info msg="Active TLS secret cattle-system/cattle-webhook-tls (ver=) (count -1): map[]"

@brandond brandond requested a review from a team as a code owner September 12, 2025 21:17
@brandond brandond requested a review from tomleb September 12, 2025 21:17
@brandond brandond assigned marytlf and unassigned marytlf Sep 12, 2025
@brandond brandond requested a review from marytlf September 12, 2025 21:18
@brandond brandond merged commit 7ad4185 into rancher:main Sep 15, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomleb tomleb tomleb approved these changes

@marytlf marytlf marytlf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brandond @tomleb @marytlf