Use size-optimized docker build for on-push-CI as well #171
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
In theory this should use less resources, because common parts of the Dockerfiles are only built once. But in reality the overhead of
leads to slower CI runs. They grow from 7 minutes (all cached situation) to 11 minutes (all cached). Given that the complexity is also raised, I think it's better to keep the CI runs as they are. |
The advantage is that the same cache entries are used as the publish and release workflows. The downside is that more CI jobs are used in cascade, slowing down the overall CI run.
larskanis
force-pushed
the
size-on-push
branch
from
09e6d45 to
5b9d345
Compare
larskanis
force-pushed
the
size-on-push
branch
from
207a7bb to
c75035c
Compare
larskanis
force-pushed
the
size-on-push
branch
2 times, most recently
from
4d0d6a7 to
c9d735a
Compare
larskanis
force-pushed
the
size-on-push
branch
from
c9d735a to
7a122bf
Compare
The gha type is faster, but for some reason the gha cache type is not reliable. It repeatedly has cache misses when there should be a cache hit. The local storage cache in combination with achtions/cache doesn't show this behaviour.
larskanis
force-pushed
the
size-on-push
branch
from
0a5c87c to
c9181e6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an addition to #170 . It rearranges the CI jobs so that common parts of the per platform Dockerfiles are built by a separate job and are re-used by subsequent depending docker build runs.