Add support for Google Analytics 4 #164
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bumi
approved these changes
Aug 2, 2023
|
@botandrose any chance to add specs to get the PR merged? |
|
If I get word that it would be merged afterwards, I'll put in the work! |
|
@bumi is that all that's needed for this to be merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, thanks for rack-tracker! I've been using it for years, and so I really appreciate your efforts with it!
Google is pushing everyone onto GA4, so I want to add support for it to this gem. @ad-zaitsev already forked it and did an implementation, which seems to work just fine. I've simply copied it here in hopes to get it into an eventual gem release. I see that its lacking test and documentation, so I'm happy to put in the work to add those, if you are amenable to merging it afterwards!
Green light?