Skip to content

Feature/webpack runner rework #3144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 9, 2021
Merged

Feature/webpack runner rework #3144

merged 3 commits into from
Sep 9, 2021

Conversation

@guillaumebriday
Copy link
Member

@guillaumebriday guillaumebriday commented Aug 28, 2021

Topics:

  • Cleaning the WebpackRunner class
  • Adding --no-deprecation flag.
  • Allow the usage of Webpack default commands without --config by default.

Fix: #3138

@guillaumebriday guillaumebriday requested a review from dhh August 28, 2021 11:31
@guillaumebriday guillaumebriday mentioned this pull request Aug 28, 2021
Closed
@tagliala
Copy link
Contributor

tagliala commented Aug 28, 2021 •
edited
Loading

Hi @guillaumebriday , in order to completely fix #3138, shouldn't --colors be removed from the Readme?

@guillaumebriday
Copy link
Member Author

guillaumebriday commented Aug 28, 2021

Nice catch, I will remove it too 👍

@dhh dhh merged commit f0d2913 into rails:master Sep 9, 2021
@guillaumebriday guillaumebriday deleted the feature/webpack-runner-rework branch September 9, 2021 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dhh dhh Awaiting requested review from dhh

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Docs: --colors is not a valid options in webpack 5

3 participants

@guillaumebriday @tagliala @dhh