es6 variables and style changes #110
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5minpause
changed the title
|
Omitting semicolons is intentional, but we should indeed use |
5minpause
force-pushed
the
5minpause-es6-variables
branch
from
f1dd2b6 to
a2c7e35
Compare
|
Great, I removed the commit that added the semicolons. |
|
Awesome, thanks! Omitting semicolons for aesthetics. None of the ES6 code I personally write has semicolons, unless I explicitly need to disambiguate something. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since you use ES2017 the variable declarations should be made using
letandconstinstead ofvar. Also in the webpack configuration files and in the react-files there were semicolons missing from the end of the lines. I do not know whether this was intentional.Since it is marked as a warning when using the AirBNB ESlint configuration (which is widely used), I added these.
Let me know what you think.