Deprecate relying on default exit_on_failure? #625
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit a88ea56792c9a40d803f025ffcb63e8ae35bf5ff.
marcandre
force-pushed
the
deprecate_exit
branch
from
33891c5 to
cc8e8fd
Compare
|
Mm, my branch was broken, sorry for that. Should be fixed now. |
deivid-rodriguez
approved these changes
Oct 23, 2018
This was referenced Dec 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This forces implementers in defining
exit_on_failure?, or else a deprecation warning is issued on error. See discussion in #621