Prevent duplicate tailwind css reference #412
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brunoprietog
reviewed
Oct 9, 2024
There was a problem hiding this comment.
I think this is not the way to go, since :app will try to load all the css that must pass through the Tailwind transpiler in its pure state on each page, something that only works if you use only vanilla CSS. What we really need to do is to remove those 2 default lines in Rails 8 so that the only entry point is the Tailwind build.
|
@rip747 This change fails the tests in CI for the reasons @brunoprietog mentions. I'm going to close this, but please feel free to ask questions and if you feel like it propose a change upstream in Rails. |
|
I've drafted a pull request that I think fixes this issue at #473 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On a newly generated 8.0.0.beta1 app it seems that the tailwind.css is referenced twice with the head of the generated layout
it seems that the injected stylesheet_link_tag is including the tailwind stylesheet
it is automatically included from the 'app' stylesheet call from the app/build directory
<%= stylesheet_link_tag :app, "data-turbo-track": "reload" %>removing the tailwind reference
prevents the duplicate in the generated layout