Drop base64 gem from dependency #810
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
tricknotes
force-pushed
the
drop-base64
branch
from
f6514c4 to
2ab7403
Compare
This following warning is shown in test. ``` /Users/ryunosuke.sato/src/github.com/rails/sprockets/lib/sprockets/mime.rb:2: warning: base64 was loaded from the standard library, but will no longer be part of the default gems starting from Ruby 3.4.0. You can add base64 to your Gemfile or gemspec to silence this warning. ``` Instead of adding base64 to dependency, the usage of `Base64#strict_encode64` and `Base64#encode64` have replaced with `Array#pack`.
tricknotes
force-pushed
the
drop-base64
branch
from
2ab7403 to
b8eaeef
Compare
|
@byroot |
|
👋🏻 Hey, y'all, thanks for getting this update in. Would it be possible to cut a new point release to RubyGems with this fix? |
|
I just released 4.2.2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This following warning is shown in test.
Instead of adding base64 to dependency, the usage of
Base64#strict_encode64andBase64#encode64have replaced withArray#pack.Also, this PR fixes CI for Ruby 3.4-dev.
Note: Similar PRs are here
base64gem from runtime dependency rubocop/rubocop#12313base64gem dependency socketry/protocol-http#51