has_many: support chaining where clauses
#455
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modify the `ActiveResource::Associations` module's `has_many` definition to invoke `Base.all`, rather than `Base.find(:all)` in order to utilize the deferred record fetching introduced in [rails#422][]. ```ruby class Person < ActiveResource::Base self.site = "https://example.com" has_many :people end person = Person.find(1) # => GET /people/1.json person.people # => GET /people.json?person_id=1 person.people.where(name: "Related") # => GET /people.json?person_id=1&name=Related ``` [rails#422]: rails#422
seanpdoyle
force-pushed
the
has-many-where-chain
branch
from
3e9aae6 to
a868196
Compare
seanpdoyle
commented
Oct 28, 2025
| attributes[method_name] | ||
| elsif !new_record? | ||
| instance_variable_set(ivar_name, reflection.klass.find(:all, params: { "#{self.class.element_name}_id": self.id })) | ||
| instance_variable_set(ivar_name, reflection.klass.all(params: { "#{self.class.element_name}_id": self.id })) |
There was a problem hiding this comment.
Alternatively, this could use .where
Suggested change
| instance_variable_set(ivar_name, reflection.klass.all(params: { "#{self.class.element_name}_id": self.id })) | |
| instance_variable_set(ivar_name, reflection.klass.where("#{self.class.element_name}_id": self.id)) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modify the
ActiveResource::Associationsmodule'shas_manydefinition to invokeBase.all, rather thanBase.find(:all)in order to utilize the deferred record fetching introduced in #422.