allow to set custom expires_in #73
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On apps with controllers that only use the default CRUD actions
it is quite common to extract the action caching logic to a concern
to be able to the share the same logic between controllers and to
reason about the caching strategy in a single place, the concern
could be similar to this one:
```
module SetActionCaching
extend ActiveSupport::Concern
included do
caches_action :index, :show,
cache_path: :cache_path, expires_in: 2.hours, if: :cacheable_action?
end
...
end
```
The issue with this approach is that action caching does not allow to
set a custom `expires_in` which force all controllers to use the same
expire time, this PR allow to set a custom `expires_in` time using a
symbol as `caches_action :index, expires_in: :set_expires_in` or even a
custom object which will allow to extract all the logic into the concern.
This can be also useful if different expire times for a single action
are needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On apps with controllers that only use the default CRUD actions it is quite common to extract the action caching logic to a concern to be able to the share the same logic between controllers and to reason about the caching strategy in a single place, the concern could be similar to this one:
The issue with this approach is that action caching does not allow to set a custom
expires_inwhich force all controllers to use the same expire time, this PR allow to set a customexpires_intime using a symbol ascaches_action :index, expires_in: :set_expires_inor even a custom object which will allow to extract all the logic into the concern. This can be also useful if different expire times for a single action are needed.