Build Windows binary gem for Ruby-2.5 #412
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
NICE! Would you mind adding an entry to the CHANGELOG too and I'll merge this in and get a new version pushed? |
This updates rake-compiler-dock for Ruby-2.5. Use parallel build to use several cores for build.
larskanis
force-pushed
the
rubyinstaller-2.5
branch
from
3febd44 to
fca6113
Compare
Member
Author
|
OK, I changed the commit to include a CHANGELOG entry. |
Member
Author
|
@metaskills I tested |
Member
|
No thank you Lars! That was really nice of you to followup and test like that. Cheers! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates rake-compiler-dock for Ruby-2.5.
Use parallel build to use several cores for build.
Fixes #408 .