Don't reset use_utf16 option, when initializing with false #314
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
||= is a deceiving operator for Boolean values. It could mean assign-if-nil or assign-if-false. It is just a short-hand for `a = a || new_value`
vijay-koppala
changed the title
Member
|
Thanks... maybe we should use idiomatic Ruby instead. Would this work? opts[:use_utf16] = opts.fetch(:use_utf16) { true } |
Member
|
Actually, I like this better. Merged in :) |
metaskills
added a commit
that referenced
this pull request
Nov 27, 2016
aharpervc
pushed a commit
to aharpervc/tiny_tds
that referenced
this pull request
Apr 9, 2020
…server#314) * Don't reset use_utf16 option, when tried to initialize with false ||= is a deceiving operator for Boolean values. It could mean assign-if-nil or assign-if-false. It is just a short-hand for `a = a || new_value` * Considered non-existence option as true * Initialized "use_utf16" Ruby Symbol Object
aharpervc
pushed a commit
to aharpervc/tiny_tds
that referenced
this pull request
Apr 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
||= is a deceiving operator for Boolean values. It could mean, assign-if-nil or assign-if-false. It is just a short-hand for
a = a || new_value