Fix application name sent to TinyTDS #941
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpolicarpo
reviewed
Sep 1, 2021
…'configure_application_name' method.
aidanharan
commented
Sep 2, 2021
lavika
pushed a commit
to lavika/activerecord-sqlserver-adapter
that referenced
this pull request
Sep 26, 2023
* Fix application name * Updated changelog * No longer support configuring the application name by overriding the 'configure_application_name' method. Co-authored-by: Aidan Haran <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the application name so that the Rails application name can be used for the database connection created by TinyTDS.
During the refactoring in #917 the method
configure_application_nameshould have been moved from an instance to a class method. This resulted in the application name never getting set to the Rails application name as the call toconfigure_application_namewould throw aNameErrorexception, which resulted in the application name being set tonil. The TinyTds client would ignore theniland use 'TinyTds' as the application name instead (https://github.com/rails-sqlserver/tiny_tds/blob/e3e79a030271891b11b6e7676382fe31f389b099/lib/tiny_tds/client.rb#L50).