Rails 6.1: Check if TinyTDS connection failed when using raw_connection_run/execute_procedure #918
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aidanharan
changed the title
aidanharan
changed the title
aidanharan
force-pushed
the
check-tinytds-results-for-false
branch
from
27e1ed1 to
7222e4b
Compare
Contributor
Author
|
Closing as similiar changes have been made in #903 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whenever we call
@connection.executewe should check if the return value isfalse, which indicates that the connection has failed. Previously we were only checking the return value inraw_connection_dobut I see no reason why we should not also check it inraw_connection_runandexecute_procedure.This issue was brought up by @mgrunberg in #903 (comment)
References:
falseif connection fails: https://github.com/rails-sqlserver/tiny_tds/blob/77341a31dbed0299ae6160ec75f00089f95880c7/ext/tiny_tds/client.c#L256