Skip to content

Conversation

@midnight-wonderer
Copy link
Contributor

@midnight-wonderer midnight-wonderer commented Dec 14, 2019

Hi there,
We have connection issues in our production environment.
It is supposed to be an easy fix but we cannot safely rescue the exception because it is billed as an ActiveRecord::StatementInvalid exception.

I add my exception translation where it is supposed to be. It is not feasible to emulate the same issue in tests so I simply don't add any test.

Hopes you guys could release a quick fix version soon.

@midnight-wonderer
Copy link
Contributor Author

BTW the full message is TinyTds::Error: Adaptive Server connection timed out

@midnight-wonderer midnight-wonderer force-pushed the feature/connection-timeout-error-translation branch from 739259d to 968d8f3 Compare December 14, 2019 16:08
@wpolicarpo
Copy link
Member

@midnight-wonderer can you rebase your branch and resolve the conflicts?

@midnight-wonderer midnight-wonderer force-pushed the feature/connection-timeout-error-translation branch from 968d8f3 to 74a532e Compare May 14, 2020 03:51
@wpolicarpo wpolicarpo merged commit c52b1f7 into rails-sqlserver:master May 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants