Add link to info on setting polymorphic serializers #1906
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Rio517, thanks for your PR! By analyzing the annotation information on this pull request, we identified @marcgarreau, @bf4 and @yogeshjain999 to be potential reviewers |
| @@ -140,7 +140,7 @@ class PictureSerializer < ActiveModel::Serializer | |||
| end | |||
| ``` | |||
|
|
|||
| For more context, see the [tests](../../test/adapter/polymorphic_test.rb) for each adapter. | |||
| You can specify the serializers by [overriding serializer_for](https://github.com/rails-api/active_model_serializers/blob/master/docs/general/serializers.md#overriding-association-serializer-lookup). For more context about polymorphic relationships, see the [tests](../../test/adapter/polymorphic_test.rb) for each adapter. | |||
There was a problem hiding this comment.
@Rio517 awesome, let's use a relative link (serializers.md#overriding-association-serializer-lookup)
|
@Rio517 do you want to finish this up? :-) |
While this same document provides details on how to override the serializer_for, not all users will realize this could be used to set the sterilizers for polymorphic relationships. This change just adds a link to that documentation and makes that point obvious.
|
LGTM |
richmolj
pushed a commit
to richmolj/active_model_serializers
that referenced
this pull request
Sep 16, 2016
While this same document provides details on how to override the serializer_for, not all users will realize this could be used to set the sterilizers for polymorphic relationships. This change just adds a link to that documentation and makes that point obvious.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Add a reference to show how to set sterilizers on polymorphic relationships.
Changes
Add a single sentence with a link that points to a header further down the page.
Additional helpful information
While this same document provides details on how to override the serializer_for, not all users will realize this could be used to set the sterilizers for polymorphic relationships. This change just adds a link to that documentation and makes that point obvious.