ApplicationSerializer not picked up by generator

[ganlron]

Expected behavior vs actual behaviour

I've created an ApplicationSerializer in app/serializers/application_serializer.rb and was expecting rails g serializer foo to inherit from this, but it still defaults to ActiveModel::Serializer.

I can get around this by passing ApplicationSerializer with --parent and it works, but wasn't expected behaviour

Environment

Rails 5.0.0.1
ruby 2.3.1p112

[bf4]

@ganlron which AMS version? I'm unfamiliar with --parent. You ran rails g serializer User --parent ApplicationSerializer?

[bf4]

Oh, ha, it's our own option

active_model_serializers/lib/generators/rails/serializer_generator.rb

Line 9 in 49ee823

class_option :parent, type: :string, desc: 'The parent class for the generated serializer'

Looks like it's because the generator checks if the ApplicationSerializer is defined, and it may not have been loaded yet? So, logic there could be better?

[ganlron]

LOL ya, was your option :)

I was trying to figure out how it would be loaded in the generator flow. Maybe the flow has changed for Rails 5, as simply creating an Application Serializer doesn't seem to cut it anymore.

[bf4]

I'm pretty sure you could fix this by changing the defined? check

      def parent_class_name
        options[:parent] or  ::ApplicationSerializer.name
      rescue NameError
          'ActiveModel::Serializer'
      end