Skip to content

cleanup implementation of add_buf_to_tab #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

cleanup implementation of add_buf_to_tab #4

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 13 additions & 11 deletions lua/tabline_framework/toys.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,17 +16,19 @@ end

local function add_buf_to_tab()
local tab = vim.api.nvim_get_current_tabpage()
local win = vim.api.nvim_tabpage_get_win(tab)
local buf = vim.api.nvim_win_get_buf(win)
local is_valid = vim.api.nvim_buf_is_valid(buf)
local is_listed = vim.api.nvim_buf_get_option(buf, 'buflisted')
if not is_valid or not is_listed then return end

local list = get_tab_buffers(tab)

if not vim.tbl_contains(list, buf) then table.insert(list, buf) end

vim.api.nvim_tabpage_set_var(tab, 'tabline_framework_buffer_list', list)
local windows = vim.api.nvim_tabpage_list_wins(tab)
buffers_in_tab = {}
for _,v in ipairs(windows) do
local buf = vim.api.nvim_win_get_buf(v)

local is_valid = vim.api.nvim_buf_is_valid(buf)
local is_listed = vim.api.nvim_buf_get_option(buf, 'buflisted')
if is_valid and is_listed then
local name = vim.api.nvim_buf_get_name(buf)
table.insert(buffers_in_tab, name)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It must return a list of buffers ids (not names) because this function is intended to work as make_bufs input.

end
end
vim.api.nvim_tabpage_set_var(tab, 'tabline_framework_buffer_list', buffers_in_tab)
end


Expand Down