Skip to content

Conversation

@jisantuc
Copy link
Contributor

@jisantuc jisantuc commented May 5, 2021

Related Issue(s): stac-utils/stac-fastapi#124

Proposed Changes:

  1. Don't deactivate other query params when ids is passed to item search

PR Checklist:

  • This PR is made against the dev branch (all proposed changes except releases should be against dev, not master).
  • This PR has no breaking changes.
  • I have added my changes to the CHANGELOG or a CHANGELOG entry is not required.

@philvarner
Copy link
Collaborator

Also just filed stac-utils/stac-fastapi-pgstac#31

| datetime | string | OAFeat | Single date+time, or a range ('/' seperator), formatted to [RFC 3339, section 5.6](https://tools.ietf.org/html/rfc3339#section-5.6). Use double dots `..` for open date ranges. |
| intersects | GeoJSON Geometry | STAC | Searches items by performing intersection between their geometry and provided GeoJSON geometry. All GeoJSON geometry types must be supported. |
| ids | \[string] | STAC | Array of Item ids to return. All other filter parameters that further restrict the number of search results (except `next` and `limit`) are ignored |
| ids | \[string] | STAC | Array of Item ids to return. |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to rephrase this, but I think it's fine for now.

@jisantuc jisantuc changed the title Simplify search param interactions Don't deactivate other search parameters when filtering with ids May 5, 2021
@jisantuc jisantuc merged commit 7484ac9 into dev May 5, 2021
@jisantuc jisantuc deleted the js/simplify-search-param-interactions branch May 5, 2021 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants