Skip to content

Collect consumed metric message by message #700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 31, 2025
Merged

Collect consumed metric message by message #700

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions src/main/java/com/rabbitmq/stream/impl/ServerFrameHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -451,7 +451,6 @@ static int handleDeliver(
}

metricsCollector.chunk(numEntries);
long messagesRead = 0;
MutableBoolean messageIgnored = new MutableBoolean(false);

while (numRecords != 0) {
Expand Down Expand Up @@ -482,7 +481,7 @@ static int handleDeliver(
subscriptionId, offset, chunkTimestamp, committedOffset, chunkContext);
messageIgnored.set(false);
} else {
messagesRead++;
metricsCollector.consume(1);
}
numRecords--;
offset++; // works even for unsigned long
Expand Down Expand Up @@ -551,7 +550,7 @@ static int handleDeliver(
subscriptionId, offset, chunkTimestamp, committedOffset, chunkContext);
messageIgnored.set(false);
} else {
messagesRead++;
metricsCollector.consume(1);
}
numRecordsInBatch--;
offset++; // works even for unsigned long
Expand All @@ -564,7 +563,6 @@ static int handleDeliver(
}
}
}
metricsCollector.consume(messagesRead);
return read;
}

Expand Down