Skip to content

Conversation

@Gsantomaggio
Copy link
Member

Fixes #218

Signed-off-by: Gabriele Santomaggio [email protected]

Fixes #218

Signed-off-by: Gabriele Santomaggio <[email protected]>
@Gsantomaggio
Copy link
Member Author

@bSirotkovic do you have a chance to test it?

thank you

@lukebakken lukebakken added this to the 1.1 milestone Jan 24, 2023
@lukebakken lukebakken self-requested a review January 24, 2023 15:42
@codecov
Copy link

codecov bot commented Jan 24, 2023

Codecov Report

Base: 92.11% // Head: 92.20% // Increases project coverage by +0.09% 🎉

Coverage data is based on head (85ddbfb) compared to base (7f2e9f7).
Patch coverage: 63.63% of modified lines in pull request are covered.

❗ Current head 85ddbfb differs from pull request most recent head 987472b. Consider uploading reports for the commit 987472b to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #219      +/-   ##
==========================================
+ Coverage   92.11%   92.20%   +0.09%     
==========================================
  Files          94       94              
  Lines        8254     8267      +13     
  Branches      650      648       -2     
==========================================
+ Hits         7603     7623      +20     
+ Misses        513      502      -11     
- Partials      138      142       +4     
Impacted Files Coverage Δ
RabbitMQ.Stream.Client/RoutingClient.cs 93.75% <63.63%> (-4.87%) ⬇️
RabbitMQ.Stream.Client/WireFormatting.cs 71.18% <0.00%> (-3.39%) ⬇️
Tests/ClientTests.cs 96.07% <0.00%> (-1.31%) ⬇️
RabbitMQ.Stream.Client/Reliable/Consumer.cs 100.00% <0.00%> (ø)
RabbitMQ.Stream.Client/Reliable/ConsumerFactory.cs 90.58% <0.00%> (+0.11%) ⬆️
RabbitMQ.Stream.Client/Reliable/Producer.cs 78.00% <0.00%> (+0.29%) ⬆️
RabbitMQ.Stream.Client/Client.cs 91.85% <0.00%> (+0.98%) ⬆️
RabbitMQ.Stream.Client/RawConsumer.cs 85.52% <0.00%> (+1.35%) ⬆️
RabbitMQ.Stream.Client/CreditResponse.cs 70.00% <0.00%> (+70.00%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@bSirotkovic
Copy link

@Gsantomaggio
Will get back to you tomorrow

@Gsantomaggio Gsantomaggio modified the milestones: 1.1, 1.1.1 Jan 26, 2023
@bSirotkovic
Copy link

bSirotkovic commented Jan 27, 2023

Hi, the initial connection works great. I pass all of our node endpoints to the StreamSystemConfig and the initial connect is great. Multiple producers connect to different leader nodes.

Haven't had the chance to test out node falling out.
When do you think we can see this included in a release?

@Gsantomaggio
Copy link
Member Author

@bSirotkovic, we should release it next week.

@Gsantomaggio Gsantomaggio marked this pull request as ready for review January 28, 2023 07:40
@Gsantomaggio Gsantomaggio merged commit b5bfe4c into main Jan 31, 2023
@Gsantomaggio Gsantomaggio deleted the add_getendpoint_type branch January 31, 2023 12:39
@Gsantomaggio
Copy link
Member Author

@lukebakken lukebakken modified the milestones: 1.1.1, 1.2 Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Change the way to lookup the advertised_host

4 participants