-
Notifications
You must be signed in to change notification settings - Fork 48
Decode the address type #219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Fixes #218 Signed-off-by: Gabriele Santomaggio <[email protected]>
|
@bSirotkovic do you have a chance to test it? thank you |
Codecov ReportBase: 92.11% // Head: 92.20% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #219 +/- ##
==========================================
+ Coverage 92.11% 92.20% +0.09%
==========================================
Files 94 94
Lines 8254 8267 +13
Branches 650 648 -2
==========================================
+ Hits 7603 7623 +20
+ Misses 513 502 -11
- Partials 138 142 +4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
@Gsantomaggio |
|
Hi, the initial connection works great. I pass all of our node endpoints to the StreamSystemConfig and the initial connect is great. Multiple producers connect to different leader nodes. Haven't had the chance to test out node falling out. |
|
@bSirotkovic, we should release it next week. |
Fixes #218
Signed-off-by: Gabriele Santomaggio [email protected]