Skip to content

rabbitmq.conf: restrict raft.segment_max_entries to [1; (u16 max value -1)] #9737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 19, 2023
Merged

rabbitmq.conf: restrict raft.segment_max_entries to [1; (u16 max value -1)] #9737

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion deps/rabbit/priv/schema/rabbit.schema
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2365,7 +2365,7 @@ end}.

{mapping, "raft.segment_max_entries", "ra.segment_max_entries", [
{datatype, integer},
{validators, ["non_zero_positive_integer"]}
{validators, ["non_zero_positive_integer", "non_zero_positive_16_bit_integer"]}
]}.

{translation, "ra.segment_max_entries",
Expand Down Expand Up @@ -2629,6 +2629,11 @@ fun(Int) when is_integer(Int) ->
Int >= 1
end}.

{validator, "non_zero_positive_16_bit_integer", "number should be between 1 and 65535",
fun(Int) when is_integer(Int) ->
(Int >= 1) and (Int =< 65535)
end}.

{validator, "valid_regex", "string must be a valid regular expression",
fun("") -> false;
(String) -> {Res, _ } = re:compile(String),
Expand Down
4 changes: 2 additions & 2 deletions deps/rabbit/test/config_schema_SUITE_data/rabbit.snippets
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -851,9 +851,9 @@ credential_validator.regexp = ^abc\\d+",
[]},

{raft_segment_max_entries,
"raft.segment_max_entries = 65536",
"raft.segment_max_entries = 32768",
[{ra, [
{segment_max_entries, 65536}
{segment_max_entries, 32768}
]}],
[]},

Expand Down