Mark AMQP 1.0 properties chunk as binary #7001
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is marked as an UTF8 string, which is not, so strict AMQP 1.0 codecs can fail.
Instead of converting from AMQP 091 back to AMQP 1.0. This is for AMQP 1.0 properties, application properties, and message annotations.
In the rabbit_msg_record module, mostly. Before this commit, only one Data section was supported. Now multiple Data sections, multiple Sequence sections, and an AMQP value section are supported.
acogoluegnes
added a commit
to rabbitmq/rabbitmq-stream-java-client
that referenced
this pull request
Jan 31, 2023
kjnilsson
requested changes
Jan 31, 2023
Contributor
kjnilsson
left a comment
kjnilsson
left a comment
There was a problem hiding this comment.
A couple of nitpicks and a question otherwise LGTM!
kjnilsson
approved these changes
Jan 31, 2023
mergify bot
pushed a commit
that referenced
this pull request
Jan 31, 2023
* Mark AMQP 1.0 properties chunk as binary It is marked as an UTF8 string, which is not, so strict AMQP 1.0 codecs can fail. * Re-use AMQP 1.0 binary chunks if available Instead of converting from AMQP 091 back to AMQP 1.0. This is for AMQP 1.0 properties, application properties, and message annotations. * Test AMQP 1.0 binary chunk reuse * Support AMQP 1.0 multi-value body better In the rabbit_msg_record module, mostly. Before this commit, only one Data section was supported. Now multiple Data sections, multiple Sequence sections, and an AMQP value section are supported. * Add test for non-single-data-section AMQP 1.0 message * Squash some Dialyzer warnings * Silent dialyzer for a function for now * Fix type declaration, use type, not atom * Address review comments (cherry picked from commit 1425e5c)
acogoluegnes
added a commit
that referenced
this pull request
Jan 31, 2023
Mark AMQP 1.0 properties chunk as binary (backport #7001)
Gsantomaggio
added a commit
to rabbitmq/rabbitmq-stream-dotnet-client
that referenced
this pull request
Feb 14, 2023
The test StreamShouldReadTheAmqp10PropertiesMessages now works correctly due of rabbitmq/rabbitmq-server#7001 so we removed the workaround for the issue Signed-off-by: Gabriele Santomaggio <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the support for AMQP 1.0 message format, especially in the context of streams: