AMQP 1.0: Support the modified outcome #6228
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some client libraries (QPid) will automatically send a disposition with the 'modified' outcome in response to a client local message TTL expiry. To support this case and others we treat 'modified' the same as 'accepted' and simply ack the message back to the queue. This change also contains some API extensions to the amqp10_client to better support sending the various delivery states (outcomes).
lukebakken
force-pushed
the
amqp10-modified-outcome
branch
from
578de52 to
802688a
Compare
lukebakken
approved these changes
Oct 24, 2022
Collaborator
lukebakken
left a comment
lukebakken
left a comment
There was a problem hiding this comment.
Makes as much sense as it can given my AMQP 1.0 knowledge 😉 I reverted the removal of the symlinks and Makefile change.
michaelklishin
approved these changes
Oct 25, 2022
michaelklishin
added a commit
that referenced
this pull request
Oct 25, 2022
AMQP 1.0: Support the modified outcome (backport #6228)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some client libraries (QPid) will automatically send a disposition with the 'modified' outcome in response to a client local message TTL expiry.
To support this case and others we treat 'modified' the same as 'accepted' and simply ack the message back to the queue.
This change also contains some API extensions to the amqp10_client to better support sending the various delivery states (outcomes).
Fixes #6121