QQ: don't try to contact non-connected nodes for stats #6183
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some systems may incur a substantial latency penalty when attempting reconnections to down nodes so to avoid this some stat related functions that gather info from all QQ member nodes no only try those nodes that are connected. This should help keeping things like the mgmt API functions and ctl commands a bit more responsive.
kjnilsson
changed the title
ansd
requested changes
Oct 26, 2022
ansd
reviewed
Oct 28, 2022
michaelklishin
added a commit
that referenced
this pull request
Oct 28, 2022
QQ: don't try to contact non-connected nodes for stats (backport #6183)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some systems may incur a substantial latency penalty when attempting reconnections to down nodes so to avoid this some stat related functions that gather info from all QQ member nodes now only try those nodes that are connected. This should help keeping things like the mgmt API functions and ctl commands a bit more responsive when RabbitMQ nodes are down.
Context: #6048