Make selenium component images configurable #14811
Open
+14
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
This PR makes all selenium component images configurable. Some components were already configurable, but the variable declaration was inconsistent i.e. some components declared the image variable at the top of the script, others, inside an
initfunction. This PR makes the image variable declaration consistent.This PR also makes it easy to override them in CI. For example, to use a proxy to access DockerHub or GHCR.
Types of Changes
What types of changes does your code introduce to this project?
Put an
xin the boxes that applyFurther comments
We should backport this to 4.2 and 4.1. This can wait until 4.2.0 release.